Lazy regex evaluation on Rules #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test verifying the lazy initialization behaviour when disabled and the proper failure when enabled.
pavlospt
force-pushed
the
lazy_regex_evaluation
branch
from
0b4776d
to
c871551
Compare
arturbosch
requested changes
Sep 2, 2018
| @@ -0,0 +1,29 @@ | |||
| package io.gitlab.arturbosch.detekt.api.internal | |||
There was a problem hiding this comment.
Lets move this class out from internal as it will be used by detekt-rules and maybe third party extensions.
Please add one sentence that key and default are actually used to retrieve a config property.
| it("should not fail when disabled with faulty regex pattern") { | ||
| val configValues = mapOf("active" to "false", LateinitUsage.IGNORE_ON_CLASSES_PATTERN to "*Test") | ||
| val findings = LateinitUsage(TestConfig(configValues)).lint(code) | ||
| assertThat(findings).hasSize(0) |
There was a problem hiding this comment.
You can use .isEmpty here and above in the old code :)
|
@arturbosch updated with your feedback :) |
arturbosch
approved these changes
Sep 2, 2018
|
Thanks, feel free to add yourself to the readme and create additional PR with the more regex changes :) |
|
@arturbosch Added my name in README.md! You can merge this one and I will follow up with a new one for the rest of the Rules :) |
schalkms
approved these changes
Sep 2, 2018
vanniktech
approved these changes
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the eager Regex evaluation discussed in #1064
LazyRegexclass that evaluates aRegexneeded inside a rule, only when it is requested and only once.LazyRegexinLateinitUsagerule.@arturbosch I would be more than happy to migrate the rest of the
Regexusages insideRules (if any) once you think this is a proper solution!