Fix issue with wrong report name #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When splitting a report path provided on JCommander, given a Windows path would cause a false split, that would continue the execution despite the assert check. This commit fixes this issue by the assumption that an absolute path on Windows systems, will contain the current disk drive's letter. Resolves: detekt#1123 - detekt#1141
vanniktech
approved these changes
Sep 22, 2018
|
@vanniktech can you elaborate on that? I am afraid I did not get what you mean :P |
|
@pavlospt I think we should check the entries of the report for equality, not just checking the size. This caused the bug in the first place. @vanniktech please correct me if you have other intentions. it("should parse multiple report entries") {
assertThat(reports).hasSize(4)
} |
|
@schalkms sure, i can update the test to assert on that! |
Mauin
approved these changes
Sep 22, 2018
|
@schalkms @vanniktech I enhanced |
schalkms
approved these changes
Sep 22, 2018
vanniktech
approved these changes
Sep 22, 2018
arturbosch
reviewed
Sep 23, 2018
| @@ -11,10 +11,25 @@ import java.nio.file.Paths | |||
| */ | |||
| data class ReportPath(val kind: String, val path: Path) { | |||
| companion object { | |||
| private const val NUM_OF_PARTS_UNIX = 2 | |||
| private const val NUM_OF_PARTS_WINDOWS = 3 | |||
There was a problem hiding this comment.
waaah, jupp I never use windows >.<
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting a report path provided on JCommander, given a Windows path
would cause a false split, that would continue the execution despite the assert check.
This commit fixes this issue by the assumption that an absolute path on Windows
systems, will contain the current disk drive's letter.
Resolves: #1123 - #1141