Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report created at the wrong place #1123

Closed
Tolriq opened this issue Sep 15, 2018 · 4 comments · Fixed by #1145
Closed

HTML report created at the wrong place #1123

Tolriq opened this issue Sep 15, 2018 · 4 comments · Fixed by #1145

Comments

@Tolriq
Copy link

Tolriq commented Sep 15, 2018

RC9 / Windows 10 / Gradle 4.10.1

subprojects {
    apply plugin: 'io.gitlab.arturbosch.detekt'
    detekt {
        reports {
             html.enabled = true
        }
     }
}

Will create the html reports as "D" at the root of each module.
But will correctly create the detekt folder at build/reports/detekt

adding a destination for example:

destination = file("build/reports/failfast.html")

Does not change the behavior and the D files are still created (but no more the folder in reports)

@marschwar
Copy link
Contributor

marschwar commented Sep 21, 2018

That is very weird. Could you please enable debug, rerun the task and provide the logged call of the cli. What do you mean with "D"? Is that the name of the html file?

detekt {
  debug = true
}

@Tolriq
Copy link
Author

Tolriq commented Sep 22, 2018

[--input, D:_Gradle\xxx\xxx\src\main\java, --filters, ./resources/.,./build/., --config, D:_Gradle\xxx\detek
t-config.yml, --report, html:D:_Gradle\xxx\xxx\build\reports\detekt\detekt.html, --debug]

The file is named D :)

But D is the drive now that I see the command like I guess using : as a separator is an issue. Should probably add "" around the path to avoid the issue

Pretty sure #1141 is the same issue but the guy have the code on C: :)

@schalkms
Copy link
Member

Thanks for investigating this, guys! This looks like a duplicate then.

pavlospt added a commit to pavlospt/detekt that referenced this issue Sep 22, 2018
When splitting a report path provided on JCommander, given a Windows path
would cause a false split, that would continue the execution despite the assert check.

This commit fixes this issue by the assumption that an absolute path on Windows
systems, will contain the current disk drive\'s letter.

Resolves: detekt#1123 - detekt#1141
pavlospt added a commit to pavlospt/detekt that referenced this issue Sep 22, 2018
When splitting a report path provided on JCommander, given a Windows path
would cause a false split, that would continue the execution despite the assert check.

This commit fixes this issue by the assumption that an absolute path on Windows
systems, will contain the current disk drive's letter.

Resolves: detekt#1123 - detekt#1141
arturbosch pushed a commit that referenced this issue Sep 23, 2018
When splitting a report path provided on JCommander, given a Windows path
would cause a false split, that would continue the execution despite the assert check.

This commit fixes this issue by the assumption that an absolute path on Windows
systems, will contain the current disk drive's letter.

Resolves: #1123 - #1141
@arturbosch arturbosch added this to the RC9.2 milestone Sep 23, 2018
DSamaryan pushed a commit to DSamaryan/detekt that referenced this issue Oct 18, 2018
When splitting a report path provided on JCommander, given a Windows path
would cause a false split, that would continue the execution despite the assert check.

This commit fixes this issue by the assumption that an absolute path on Windows
systems, will contain the current disk drive's letter.

Resolves: detekt#1123 - detekt#1141
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants