Swallowed exception update #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauin
reviewed
Nov 13, 2018
| @@ -47,7 +47,7 @@ exceptions: | |||
| ReturnFromFinally: | |||
| active: true | |||
| SwallowedException: | |||
| active: true | |||
| active: false | |||
There was a problem hiding this comment.
Shouldn't this be generated from the rule KDoc @active tag (in this case the tag would be missing as it is not active)?
There was a problem hiding this comment.
This file is the rule config which is applied to analyzing detekt itself. I deactivated it for now, since there is some work necessary as mentioned in my initial post.
There was a problem hiding this comment.
Right! I didn't realize this was the failfast.yml. LGTM
vanniktech
approved these changes
Nov 13, 2018
arturbosch
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this PR is merged, I suggest to add a config parameter to this rule.
There are exception types like NumberFormatException and ParseException that indicate nonexceptional outcomes. This rule should ignore unhandled exception of this type specified in the config.