-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat androidTest directory and *Spek.kt files as test sources. #1456
Conversation
- '.*Test.kt' | ||
- '.*Spec.kt' | ||
- '.*Spek.kt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sneaked this one in since I think Spek 2 does use Spek instead of Spec.
Locally, I'm getting:
|
CI says:
|
Mh, just checked your branch and I can build it locally with the gradle wrapper. However the indentation of the two lines is wrong. You just used tabs but yaml spaces -> that means first three tabs and then four spaces because we do |
Okay. I should have seen that theoretically. Just today I uninstalled - https://github.com/lukechilds/github-custom-tab-size - this plugin basically adjusted the tab spacing to be the same and now that I have it no longer I saw what was actually wrong. I believe this should go green now. |
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
============================================
- Coverage 74.65% 74.63% -0.02%
+ Complexity 1717 1716 -1
============================================
Files 326 326
Lines 5176 5181 +5
Branches 939 942 +3
============================================
+ Hits 3864 3867 +3
Misses 788 788
- Partials 524 526 +2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
============================================
- Coverage 74.65% 74.63% -0.02%
+ Complexity 1717 1716 -1
============================================
Files 326 326
Lines 5176 5181 +5
Branches 939 942 +3
============================================
+ Hits 3864 3867 +3
Misses 788 788
- Partials 524 526 +2
Continue to review full report at Codecov.
|
Closes #1449