Gradle plugin: Set default path for "config" parameter #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
reviewed
Aug 3, 2019
detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/runners/ConfigExporter.kt
Show resolved
Hide resolved
That's interesting, since you didn't touch the |
schalkms
approved these changes
Aug 3, 2019
arturbosch
approved these changes
Aug 3, 2019
arturbosch
reviewed
Aug 3, 2019
| InputArgument(source) | ||
| ) | ||
|
|
||
| DetektInvoker.create(project).invokeCli(arguments.toList(), detektClasspath, name) | ||
| if (config.first().exists()) { |
There was a problem hiding this comment.
Can first() here crash when project.files(...) is empty or null?
There was a problem hiding this comment.
Very literally yes, it would fail when project files is empty. But that won't happen as the value is set a couple lines earlier and doesn't rely on external input.
That said I'll make a new ConfigArgument that accepts a single file instead of a collection to clean it up.
There was a problem hiding this comment.
It was a bit awkward to deal with a new ConfigArgument variant, so thought it's clearer to add error handling in the task itself.
To be clear this should never happen.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Generate default config at user-specified path * Set a default path for detekt's config file * Write default config file to default config path * Update config to use new config layout convention * Update baseline file location * Catch possible error if `config` collection is not expected size
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Generate default config at user-specified path * Set a default path for detekt's config file * Write default config file to default config path * Update config to use new config layout convention * Update baseline file location * Catch possible error if `config` collection is not expected size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
rootDir/config/detekt/detekt.ymlby default (to match conventions in other Gradle plugins)Closes #1262