Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify detekt rules #1898

Merged
merged 2 commits into from
Sep 7, 2019
Merged

Simplify detekt rules #1898

merged 2 commits into from
Sep 7, 2019

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Sep 6, 2019

No description provided.

This removes the need for the safe call operator (?.).
@detekt detekt deleted a comment from codecov-io Sep 6, 2019
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #1898 into master will increase coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1898      +/-   ##
============================================
+ Coverage     80.25%   80.26%   +0.01%     
- Complexity     1949     1950       +1     
============================================
  Files           325      325              
  Lines          5504     5502       -2     
  Branches       1019     1019              
============================================
- Hits           4417     4416       -1     
  Misses          557      557              
+ Partials        530      529       -1
Impacted Files Coverage Δ Complexity Δ
...ekt/rules/style/SpacingBetweenPackageAndImports.kt 83.33% <100%> (+3.33%) 23 <2> (+1) ⬆️
...o/gitlab/arturbosch/detekt/rules/style/SafeCast.kt 69.56% <66.66%> (-1.27%) 11 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c1d23...bd78d50. Read the comment docs.

@3flex 3flex merged commit 127e7e2 into detekt:master Sep 7, 2019
@schalkms schalkms deleted the simplify-rules branch September 8, 2019 10:11
@arturbosch arturbosch added this to the 1.0.2 milestone Sep 12, 2019
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
* Simplify detekt rules

* Refactor file visitor

This removes the need for the safe call operator (?.).
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
* Simplify detekt rules

* Refactor file visitor

This removes the need for the safe call operator (?.).
@arturbosch arturbosch modified the milestones: 1.0.2, 1.1.0 Sep 17, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Simplify detekt rules

* Refactor file visitor

This removes the need for the safe call operator (?.).
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Simplify detekt rules

* Refactor file visitor

This removes the need for the safe call operator (?.).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants