Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude yet unknown new build property #2201

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Conversation

arturbosch
Copy link
Member

detekt analysis on the gradle plugin is not run due to "invalid config".
This is exactly what happened to our users in #2168 and #2169 and will be fixed in 1.3.1 :).

@arturbosch arturbosch added this to the 1.3.1 milestone Dec 27, 2019
@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #2201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2201   +/-   ##
=========================================
  Coverage     81.17%   81.17%           
  Complexity     2059     2059           
=========================================
  Files           339      339           
  Lines          5891     5891           
  Branches       1073     1073           
=========================================
  Hits           4782     4782           
  Misses          535      535           
  Partials        574      574

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa21086...9f58b8b. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set a reminder TODO: remove this property.

@arturbosch arturbosch merged commit b691ce2 into master Dec 27, 2019
@arturbosch arturbosch deleted the fix-yet-unknown-property branch December 27, 2019 19:07
@arturbosch
Copy link
Member Author

I will just open a PR removing this change asap and leave it open :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants