Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config:maxIssues value to 0 #2263

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Jan 17, 2020

A sensible default value is to have zero instead of 10 reported detekt issues.
Continuing the discussion in #2262

@zsmoore
Copy link
Contributor

zsmoore commented Jan 17, 2020

This will have to be 1 instead of 0. I do however believe the wording is a bit weird. If I set maxIssues to 10 i would expect allowing 10 issues and disallowing 11. Similarly i would expect to have to set maxIssues to 0, rather than 1 in order to allow no issues.

I'm still fine pushing this through once it is updated to 1 but just a call out.

@schalkms schalkms force-pushed the schalkms-maxIssue-config branch 2 times, most recently from 980744c to 1e44378 Compare January 17, 2020 21:03
A sensible default value is to have zero instead of 10 reported detekt issues.
Continuing the discussion in #2262
@codecov-io
Copy link

Codecov Report

Merging #2263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2263   +/-   ##
=========================================
  Coverage     81.45%   81.45%           
  Complexity     2114     2114           
=========================================
  Files           349      349           
  Lines          6054     6054           
  Branches       1106     1106           
=========================================
  Hits           4931     4931           
  Misses          532      532           
  Partials        591      591
Impacted Files Coverage Δ Complexity Δ
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 76.74% <ø> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a517db9...4505b21. Read the comment docs.

@arturbosch arturbosch merged commit 8870a95 into master Jan 19, 2020
@arturbosch arturbosch deleted the schalkms-maxIssue-config branch January 19, 2020 08:12
@arturbosch arturbosch added this to the 1.5.0 milestone Jan 19, 2020
@arturbosch
Copy link
Member

@zsmoore agree maxIssues is misleading. I would also expect with maxIssues=2 to allow two issues and not to fail. I will open a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants