Rule: UnusedPrivateMember

[Mauin]

Resolves #8

This should cover unused private properties. Public properties are ignored as they might be used from other files.

[vanniktech]

Hanging fruit?

[Mauin]

Oops, was testing with this one 🙃

[schalkms]

I appreciate this changes. However, this rule needs a symbol table to function correctly for all cases.

[arturbosch]

Cool, this is a useful rule! Do you want to support parameters too? Unused private functions you can also find with the same reference counting.

I have implemented a UnusedPrivateMembers rule for java. Here is the test code:

@SuppressWarnings("ALL") public class DeadCodeDummy {

	private int deadField = 5;
	private int usedField = 5;
	private String usedString = "Hello";

	private int deadMethod(int deadParameter) {
		int deadLocaleVariable = 5;
		usedMethod("" + usedField++);
		usedField = usedString.length();
		return 5;
	}

	public int usedMethod(String usedParameter) {
		usedField = usedParameter.length() + usedString.length();
		int usedLocaleVariable = 4;
		return Integer.valueOf(usedField).compareTo(usedLocaleVariable);
	}

	public void usedParameterInAssignment(String uri, long j) {
		int i = (int) j;
		String fullUrl = uri + ("/commits/new" + 6);
		System.out.println(i + fullUrl);
	}
}

Also you should check the refences in all possible conditional statements:

	private void run(boolean go) {
		boolean used = true;
		if(go && used) {
			String concat = "";
			switch (concat) {
				case "truetrue": run2(); break;
				default: break;
			}
		}
	}

	private void run2() {
		List<String> strings = new ArrayList<>();
		for (String s : strings) {
			System.out.println("");
		}
}

[tasomaniac]

indentation seems to be off. This seems to be using spaces over tabs.

[tasomaniac]

Couldn't you do just !!? That will throw for you. If the intention is to have a custom message, then I think the exception type should better to be NullPointerException

[arturbosch]

Are there any cases where a parameter has no name?
I think it is just for anonymous objects that it can be null.
How about using safeName or nameAsSafeName (dont remember how it is called)?

[Mauin]

TIL about nameAsSafeName. Will change it!

[arturbosch]

Can you please provide some test cases with local methods and loops. Thanks :)
Cool great so far!

[Mauin]

Great idea @arturbosch I added some extra handling to catch unused loop parameters.