Implements #643 - MagicNumber ignores default values in ctor properties #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Dec 25, 2017
arturbosch
approved these changes
Dec 27, 2017
Mauin
reviewed
Dec 30, 2017
| @@ -142,6 +146,11 @@ class MagicNumber(config: Config = Config.empty) : Rule(config) { | |||
| private fun KtConstantExpression.isPartOfFunctionReturnConstant() = | |||
| parent is KtNamedFunction || (parent is KtReturnExpression && parent.parent.children.size == 1) | |||
|
|
|||
| private fun KtConstantExpression.isPartOfConstructor(): Boolean { | |||
| val isInConstructor = parent.parent.parent is KtPrimaryConstructor || parent.parent.parent is KtSecondaryConstructor | |||
There was a problem hiding this comment.
Can we extract parent.parent.parent and give it a name?
There was a problem hiding this comment.
Do you have any suggestions?
great-grandparent does not improve the readability much I think.
| @@ -142,6 +146,11 @@ class MagicNumber(config: Config = Config.empty) : Rule(config) { | |||
| private fun KtConstantExpression.isPartOfFunctionReturnConstant() = | |||
| parent is KtNamedFunction || (parent is KtReturnExpression && parent.parent.children.size == 1) | |||
|
|
|||
| private fun KtConstantExpression.isPartOfConstructor(): Boolean { | |||
There was a problem hiding this comment.
isPartOfConstructor sounds like this would also ignore instances where the constructor is called with a magic number: SomeClass(10) which is not the case, I guess.
There was a problem hiding this comment.
Thanks for this. I’ll have a look later on today. Shouldn’t detekt already have such a test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #643