New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing changes from sidekiq-alive-next #72
Conversation
Hi @andrcuns, |
@arturictus thanks, that would be cool to release these under this gem for everyone else to use. Though since I mostly did the changes for my own usecase, some of them probably should be changed a bit, like:
I can try and help out in some capacity with maintaining this project at some capacity given I extensively use it in on of my other projects and it has been very helpful. |
Hi @andrcuns, |
@arturictus Sure! Then I can try and update this branch to be a bit more backwards compatible sometime next week. |
Cool!!, I give you access :) |
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add release and changelog workflow * Set custom label for actions deps
* Move all configuration in to startup block * Check respond to on config object * Update specs * Run specs in random order
* Update gemspec metadata * Require ruby 2.7
* Add static rubocop checks * Allign arguments
* Add rake task to update version * Add version update steps
b7d9814
to
1e6b9f6
Compare
Add testing with multiple sidekiq versions Remove rack version requirement
1e6b9f6
to
5d91e0e
Compare
Hey @andrcuns, this looks great! |
It is used for the manual release action in the step which automatically updates the version number, creates a tag and then pushed it back to repo: -
name: Update version
run: |
git config user.name github-actions
git config user.email github-actions@github.com
bundle config unset deployment
bundle exec rake "version[${{ inputs.version }}]" && git push
-
name: Create tag and push to rubygems
run: bundle exec rake release
env:
GEM_HOST_API_KEY: ${{ secrets.GEM_HOST_API_KEY }} Basically it's ssh key that has access to push to repo. It doesn't have to be your personal key. The way I did it, generated new key-pair and added public key as deploy key under security settings: It's not strictly necessary but it's nice to be able to have a full new version release cycle implemented via github actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing!!, almost there
Done and Done |
Added the secrets. |
Awesome, let's do it 🚀 |
@arturictus What do You think about testing the release flow and releasing a new version? It's a pretty substantial change, while there should be no breaking changes, not sure if it should be a minor or major release. Probably still minor, since it basically just expands support and refactors some things. |
@andrcuns I think we can do a minor, let's try the releases 🤞 |
#80 fixes a bug that is present in the Sidekiq 7 compatibility here. |
This change adds the following: