Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(navview): initial implementation #62

Merged
merged 13 commits into from Apr 23, 2019
Merged

feat(navview): initial implementation #62

merged 13 commits into from Apr 23, 2019

Conversation

arturmiz
Copy link
Owner

@arturmiz arturmiz commented Apr 3, 2019

Closes #35

@arturmiz arturmiz added the enhancement New feature or request label Apr 3, 2019
@arturmiz arturmiz self-assigned this Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019 •
edited

Codecov Report

Merging #62 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #62      +/-   ##
=========================================
+ Coverage    98.7%   98.9%   +0.19%     
=========================================
  Files          32      36       +4     
  Lines         155     183      +28     
  Branches       28      34       +6     
=========================================
+ Hits          153     181      +28     
  Misses          2       2
Impacted Files Coverage Δ
src/components/navview/MenuItem.vue 100% <100%> (ø)
src/components/navview/MenuButton.vue 100% <100%> (ø)
src/components/navview/NavView.vue 100% <100%> (ø)
src/components/navview/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d7c8b...9ff0e3d. Read the comment docs.

@arturmiz arturmiz changed the title feat(navview): init commit feat(navview): initial implementation Apr 15, 2019
@codecov-io
Copy link

codecov-io commented Apr 23, 2019 •
edited by codecov bot

Codecov Report

Merging #62 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #62      +/-   ##
=========================================
+ Coverage    98.7%   98.9%   +0.19%     
=========================================
  Files          32      36       +4     
  Lines         155     183      +28     
  Branches       28      34       +6     
=========================================
+ Hits          153     181      +28     
  Misses          2       2
Impacted Files Coverage Δ
src/components/navview/MenuItem.vue 100% <100%> (ø)
src/components/navview/MenuButton.vue 100% <100%> (ø)
src/components/navview/NavView.vue 100% <100%> (ø)
src/components/navview/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d7c8b...0dea0d9. Read the comment docs.

@arturmiz arturmiz marked this pull request as ready for review April 23, 2019 13:57
@arturmiz arturmiz merged commit 2013d34 into master Apr 23, 2019
@arturmiz arturmiz deleted the feature/navview/initial-implementation branch April 23, 2019 21:57
@arturmiz arturmiz added this to the v0.6.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arturmiz arturmiz

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Implement NavView component
2 participants
@arturmiz @codecov-io