-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement Quantity values #1165
Conversation
@RickBarretto I keep testing and testing (and testing...) and I'm at the stage where I keep hitting unit-test issues. I cannot imagine what would have happened if you hadn't done it so thoroughly (especially the Arithmetics-related tests). Pure awesomeness! π |
In a galaxy far, far away, I once worked for a major software company, where the team of which I was a part, supported over 20k developers. It was our job to keep the servers and the software that they used on a daily basis, in smooth running order. You can't imagine the amount of testing that went on. And despite all of this, there were still bugs! π’ As a former database developer, I am a huge fan of unit tests. And in my own case, I used to unit-test the unit-tests! (Well, almost!). Developing software of any kind requires certain specific skills. Writing good tests requires an allied list of skills, which, unfortunately, are in short supply. So, as @drkameleon has said: great work @RickBarretto! |
@drkameleon, Appreciated! π
@celtic-coder, WOW! I can imagine this! |
First successfully-building version! π (*There must be tons of stuff to be fixed & there are a couple of cases where I simply commented-out code to make it go forward - since the updated implementations would probably take some time - but we're definitely getting there; slowly but... surely!) |
β¦r the documentation!)
πππ It's not a draft anymore and all checks have passed... |
Totally accurate! It took me some time to revise everything and - at least - make it compile but we're definitely getting closer! :) Now, I'll have to double-check everything, clean up any leftovers, write some tests and we're quite ready to go! π |
β¦eadonly-style processing in cases e.g of known array-to-array assignments
β¦pports-to-number-module [Numbers] add rational supports to its functions
So... after close to 2 months, as we were saying with @RickBarretto, I think it's time to finally merge this to the main branch, so that we can work on it, step-by-step, and on a per-issue basis, rather than keep bloating this PR again and again, until it becomes an unmanageable mess. (Is it 100% perfect? It's not. But then, nothing is...) And, of course, I'll take the time to open as many issues as possible so that we can start ironing things out. π That being said... π₯ π₯ π₯ ...ready to merge! π |
Awesome work! @drkameleon . I had the chance to play with that before the merge, as you ask me for it. And... Everything have been fan-tas-tic! Now, let's get things happen and see how it will behavior with the time. Again, awesome work as always! |
Description
Quantity values - albeit a relatively new feature in Arturo - is a rather interesting feature, that could potentially give the language an edge and allow its use in different sectors (e.g. scientific calculations, engineering, etc).
That being said, there are already a few pending issues (mostly regarding the operations between different quantities/etc), which is anything but bulletproof (at least so far).
The goals of this PR:
(*that I've been preparing for at least the past 2 weeks, writing and re-writing and re-writing)
Stretch goal
Other changes
(*Most of them directly derived from the above - or at least very relevant)
2`m
instead of2:m
) β Experimental2:3
)'a'
) β Experimentalπ¬ Discussion: @ #1144
π Also see: 1, 2 & 3
Fixes
Fixes: #1004
Fixes: #1110
Fixes: #1131
Type of change