Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guile 3.0 as a possible GUILE_PKG #8

Merged
merged 1 commit into from May 15, 2020

Conversation

a-sassmannshausen
Copy link
Contributor

Currently building of guile-dsv using Guile 3.0 or higher fails because configure only checks for Guile 2.0 or 2.2. Adding 3.0 as an option should fix this.

Currently building of guile-dsv using Guile 3.0 or higher fails because configure only checks for Guile 2.0 or 2.2.  Adding 3.0 as an option *should* fix this.
@a-sassmannshausen
Copy link
Contributor Author

Feel free to merge the pull request or follow your own workflow. I think this should fix the issue, but you may want to test first (I have not had a chance to do so!).

I encountered the issue whilst bumping the guile-dsv guix recipe and trying to add a guile3.0 recipe on top of the current 2.2 recipe.

Alex

@jackhill
Copy link

I decided to do the same thing before I saw this thread. I have tested it a little bit. guile-dsv builds and its tests pass, and some rudimentary use at the REPL works.

In addition to adding 3.0 to GUILE_PKG, I updated guix.scm and re-orered GUILE_PKG to prefer newer Guile. These changes are on my guile-3.0 branch to use as you would like.

@a-sassmannshausen
Copy link
Contributor Author

So ideally @artyom-poptsov might be able to merge in your commits when they have a moment. Happy to drop this pull request when that happens.

I will then add a guile 3.0 package variant to Guix.

@artyom-poptsov artyom-poptsov merged commit 7826dba into artyom-poptsov:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants