Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example correction that prevents author's cover images from being ove… #28

Merged
merged 3 commits into from
Jul 8, 2018

Conversation

AgeManning
Copy link
Contributor

I found that selected_cover was being overwritten by the code in the inherited template. A simple solution is to rename the variable used in the author template. Hope it helps.

@arulrajnet
Copy link
Owner

@AgeManning could you explain more about the issue..?

@AgeManning
Copy link
Contributor Author

Yep. It could be just me (I hope not) I've only just quickly looked at this.
It seemed to me, that setting an author cover path/url would not appear in the author html page.
In author.html, in about the first 30 lines, a variable selected_cover is set, if cover is defined in the author page.
This selected_cover always seems to default to the standard HEADER_COVER, regardless of the definition in AUTHORS_BIO. I believe this is because selected_cover is set in index.html which author.html inherits.

@arulrajnet arulrajnet merged commit b60a72e into arulrajnet:master Jul 8, 2018
@arulrajnet
Copy link
Owner

@AgeManning Thanks for the issues reported. We have update with the fix and updated the same in our demo site.

http://attila.demo.arulraj.net/

http://attila.demo.arulraj.net/author/zutrinken/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants