Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laika.opts file #41

Merged
merged 1 commit into from
Jul 28, 2013
Merged

Add support for laika.opts file #41

merged 1 commit into from
Jul 28, 2013

Conversation

ejoubaud
Copy link
Contributor

Adds support for taking options from a laika.opts file, modeled on Mocha's mocha.opts, since a lot of Laika's options seem borrowed from there.

This should be useful for people using Coffeescript or BDD mode.

@arunoda arunoda merged commit fad2e28 into arunoda:master Jul 28, 2013
@arunoda
Copy link
Owner

arunoda commented Jul 28, 2013

Thanks for the great PR. This is really needed 👍

published in version 0.2.16

@arunoda
Copy link
Owner

arunoda commented Jul 28, 2013

This change breaks laika to accept command line arguments. So I reverted this.
Here is the problem

  • When running laika from the git source works everything as expected.
  • But when installed globally, it only takes args from opts file only. discard any args passed from the commandline

Can you please look into this.

@ejoubaud
Copy link
Contributor Author

Ok, I reproduced the problem. Sorry about that, I'll look into it.

@arunoda
Copy link
Owner

arunoda commented Jul 28, 2013

Thanks. Looking forward for it.

On Sunday, July 28, 2013, Emmanuel Joubaud wrote:

Ok, I reproduced the problem. Sorry about that, I'll look into it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/41#issuecomment-21682710
.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants