Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multilan site - good practice with prefs #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

multilan site - good practice with prefs #10

wants to merge 1 commit into from

Conversation

Jimmi08
Copy link

@Jimmi08 Jimmi08 commented Sep 13, 2017

If you have any prefs that can be consider as "multilan", its good idea from beginning do it as multilan field.

This is discussion about it:
e107inc/e107#2591

If you add multilan option later, it will display array() and user could be confused.

@arunshekher
Copy link
Owner

@Jimmi08,
Thank you very much for the PR. Much appreciated. Will review it and apply if appropriate when mind is free enough to go through and grasp the code.

@Jimmi08
Copy link
Author

Jimmi08 commented Sep 13, 2017

@arunshekher you can close it, it just easier to show you what to should be changed than screenshots.

@arunshekher
Copy link
Owner

Got it, keep them coming, if you have time. 👍 I'm taking it also as a learning opportunity - git, php everything :)

@Jimmi08
Copy link
Author

Jimmi08 commented Sep 13, 2017

Yes, but I should create branch before post it. The same here. I haven't time but I need to learn what you did with ajax and events. Black hole for me.

@arunshekher arunshekher mentioned this pull request Sep 14, 2017
@arunshekher
Copy link
Owner

@Jimmi08, might sound really stupid to you but what is the real advantage of making the 'email_subject_line' admin preference field 'multilan'? Could you explain? So far I could not find much info on this and I haven't walked the 'i18n' path in e107 much.

@Jimmi08
Copy link
Author

Jimmi08 commented Sep 18, 2017

Don't worry. On second thought main admin can manage English. It was just my reaction where I see text field in prefs. Nothing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants