Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate completions and man page with build #35

Closed
arusahni opened this issue Oct 5, 2019 · 4 comments · Fixed by #41
Closed

Generate completions and man page with build #35

arusahni opened this issue Oct 5, 2019 · 4 comments · Fixed by #41
Assignees
@arusahni @luxrck
Labels
Hacktoberfest help wanted packaging

Comments

@arusahni
Copy link
Owner

arusahni commented Oct 5, 2019

A fun side-effect of being a git extension is that git gobbles the --help flag and seems to forwards it on to a man page for the extension. Since git-req doesn't bundle one, it fails to find the documentation. Additionally, git-req uses clap. It'd be nice if it exported completions for Bash and Zshell.

  • Have a man page generated by the build.
  • Have shell completions generated by the build.
@luxrck
Copy link
Contributor

luxrck commented Oct 5, 2019

@arusahni Hello, could I take this up ?

@arusahni
Copy link
Owner Author

arusahni commented Oct 5, 2019 •
edited

Hi @luxrck - sure thing! Let me know if you have any questions.

@luxrck luxrck mentioned this issue Oct 14, 2019
Merged
@luxrck
Copy link
Contributor

luxrck commented Oct 16, 2019

Sorry for taking this too long...... pr #39 should fix this.

@arusahni
Copy link
Owner Author

No worries - thanks for the PR! I should get to the review over the next few days - this week was busier than expected 😬

@arusahni arusahni self-assigned this Dec 30, 2019
@arusahni arusahni mentioned this issue Dec 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arusahni arusahni

@luxrck luxrck

Labels
Hacktoberfest help wanted packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shell completions arusahni/git-req
2 participants
@arusahni @luxrck