Generate man page with build.rs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #35 |
luxrck
force-pushed
the
dev
branch
5 times, most recently
from
88b1fb8
to
81468a4
Compare
|
Thanks for the pr! Regarding the shell completions, could we use the one's Clap can generate? That way git-req can support multiple shells without needing to manually maintain multiple completion files? |
|
The only reason I didn't use it is that I thought generating way is not very good for maintaining especially when we want to implement more complex completion features...... But, yes. We could generate it. |
|
Sorry for the delayed response - this looks solid! Can you rebase so I can accept the request? |
|
I was preparing for the exam last week...... |
|
No worries! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.