Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "fall through" comments to stop GCC 7 complaining #1125

Merged
merged 1 commit into from Nov 29, 2017

Conversation

martynjarvis
Copy link
Contributor

Without these comments gcc7 will complain (-Wimplicit-fallthrough).

This fixes #1109.

Without these comments gcc7 will complain (-Wimplicit-fallthrough).

This fixes arut#1109.
@andir
Copy link

andir commented Nov 25, 2017

Would appreciate this being merged to continue gcc-7 migrations :-)

@arut
Copy link
Owner

arut commented Nov 29, 2017

Thanks @martynjarvis

@martynjarvis martynjarvis deleted the fall-through-comments branch November 30, 2017 22:07
@julian-weinert
Copy link

Am I the only one or did he miss the case NORMAL?
There should be another implicit fallthrough comment in line 169 if I'm not mistaken.

zhiwsun pushed a commit to zhiwsun/nginx-rtmp-module that referenced this pull request Oct 14, 2021
Add  "fall through" comments to stop GCC 7 complaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building this with GCC 7 causes error.
4 participants