Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move print procedures to DrawedQRCode.nim module #15

Closed
aruZeta opened this issue Sep 2, 2022 · 0 comments
Closed

Move print procedures to DrawedQRCode.nim module #15

aruZeta opened this issue Sep 2, 2022 · 0 comments
Labels
roadmap This ISSUE or PR is part of the roadmap of the project.

Comments

@aruZeta
Copy link
Owner

aruZeta commented Sep 2, 2022

As commented in #14, it's dumb to have the print procedures located in the Drawing.nim module, which makes a module which should be small into a huge one (and more so with the bad code the SVG print procedures have atm lol) and also creates the need to create a wrapper procedure in the QRgen.nim module to easily use them. Hence, they should be located in DrawedQRCode.nim and exported by QRgen.nim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap This ISSUE or PR is part of the roadmap of the project.
Projects
No open projects
Status: DONE
Development

No branches or pull requests

1 participant