-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate modules in smaller modules #14
Comments
Also would be nice to do the same with the tests ... but that will be on another issue. |
Change of plans, removing |
Removing also |
I've encountered an issue when importing 2 modules named |
Now it all seems better organized! |
For example: the
DrawedQRCode.nim
module is 438 lines long (527 after #15), having some unnecessary procedures not used out of it (except for tests) which make it a really large module.Instead, it should be separated in other modules (under a directory by the name of the main module), each having a main section of what the main module really needs: in this case it would be the procedures used by
draw()
, so a module fordrawFinderPatterns
,drawAlignmentPatterns
, etc.There are other cases, like the
qr*.nim
modules which were already made like that in order to easily be imported, and would also be the case forBitArray.nim
since it only implements less than a handful of procedures (and most of the lines are doc comments themselves).- [ ]Drawing.nim
- [ ]QRCode.nim
EncodedQRCode.nim
DrawedQRCode.nim
The text was updated successfully, but these errors were encountered: