Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write better code #5

Closed
aruZeta opened this issue Aug 29, 2022 · 2 comments
Closed

Write better code #5

aruZeta opened this issue Aug 29, 2022 · 2 comments
Labels
roadmap This ISSUE or PR is part of the roadmap of the project.

Comments

@aruZeta
Copy link
Owner

aruZeta commented Aug 29, 2022 •
edited

There are some procedures, like interleaveData which have very messy code, it should be rewritten into more readable code and performance should increase / be the same as the old implementation. This does not only apply to interleaveData but to any procedure whose code may be very obscure.
aruZeta added a commit that referenced this issue Aug 29, 2022
@aruZeta
[refactor] Better interleaveData code
05033b5 
Issue: #5
aruZeta added a commit that referenced this issue Sep 4, 2022
@aruZeta
[refactor] More performant applyMaskPattern proc
ea46816 
Benchmark "Generating all 40 qr versions" went from 168ms to 152ms.

Issue: #5
@aruZeta
Copy link
Owner Author

aruZeta commented Sep 4, 2022

Note that many of the closed issues are also related to this one: #16, #15, #14, #4

aruZeta added a commit that referenced this issue Sep 8, 2022
@aruZeta
[refactor] Better print code
33fbbae 
Issue: #5
@aruZeta
Copy link
Owner Author

aruZeta commented Sep 8, 2022

I'm too lazy to refactor anything more lol, so I'm closing this.

@aruZeta aruZeta closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
roadmap This ISSUE or PR is part of the roadmap of the project.
Projects
No open projects
QRGen roadmap
Status: DONE
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aruZeta