Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom CA bundle for the api-server, and options for MetalLB #1

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

mluds
Copy link

@mluds mluds commented Oct 20, 2020

My corporate network uses TLS inspection, and so a self-signed CA cert needs to be added to the bundle for Internet access.

@cure
Copy link
Contributor

cure commented Oct 21, 2020

Hi @mluds thanks for your contribution!

Could I ask you to add a copyright header to the charts/arvados/templates/custom-ca-bundle-configmap.yaml file, please? That wasn't mentioned in the Contributing section of the README yet, sorry about that. I've added a link there that points to how to do it. If you could rebase the commit 548ee3f with that change, then I will be able to merge this PR (we have a git commit hook that requires the headers). Feel free to add yourself to the AUTHORS file, as well!

Mike Ludwig added 2 commits October 22, 2020 10:25
Arvados-DCO-1.1-Signed-off-by: Michael Ludwig <michael.david.ludwig@gmail.com>
Arvados-DCO-1.1-Signed-off-by: Michael Ludwig <michael.david.ludwig@gmail.com>
@mluds mluds changed the title support custom CA bundle for the api-server support custom CA bundle for the api-server, and options for MetalLB Oct 22, 2020
@mluds
Copy link
Author

mluds commented Oct 22, 2020

Should be all set now, thank you

@cure
Copy link
Contributor

cure commented Oct 23, 2020

Hi @mluds I am happy to merge; it looks like you missed a DCO signoff on c984df2 though, could you fix that? Sorry for the hassle.

Arvados-DCO-1.1-Signed-off-by: Michael Ludwig <michael.david.ludwig@gmail.com>
@mluds
Copy link
Author

mluds commented Oct 26, 2020

No problem, should be fixed now

@arvados-bot arvados-bot merged commit 66172e3 into arvados:master Oct 27, 2020
@cure
Copy link
Contributor

cure commented Oct 27, 2020

Thank you @mluds, merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants