Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanups #1

Merged
merged 1 commit into from Mar 25, 2024
Merged

Code cleanups #1

merged 1 commit into from Mar 25, 2024

Conversation

tetron
Copy link
Member

@tetron tetron commented Mar 20, 2024

  • Add example of keep: URL
  • make ramMin optional to suppress a spurious checker warning
  • rename quote() function to sanitize() (although it still also adds quotes)
  • don't generate empty batches when len(urls) < count

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz peter.amstutz@curii.com

* Add example of keep: URL
* make ramMin optional to suppress a spurious checker warning
* rename quote() function to sanitize() (although it still also adds quotes)
* don't generate empty batches when len(urls) < count

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
@brettcs
Copy link

brettcs commented Mar 25, 2024

lgtm, thanks

@tetron tetron merged commit fa05b5d into main Mar 25, 2024
@tetron tetron deleted the 21378-cleanup branch March 25, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants