Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes UglifyJS #43

Closed
zentuit opened this issue Aug 18, 2017 · 5 comments
Closed

Crashes UglifyJS #43

zentuit opened this issue Aug 18, 2017 · 5 comments

Comments

@zentuit
Copy link

zentuit commented Aug 18, 2017

We're using the latest package in a project and during the uglify build step, UglifyJS crashes because of index.js. Seems that built index.js still has let instead of var.

Specifically this line in index.js is causing the error:

    let tokens = state.tokens;
@arve0
Copy link
Owner

arve0 commented Aug 18, 2017

Are you using the browser build?

Browser build is not transpiled as of now.

@zentuit
Copy link
Author

zentuit commented Aug 18, 2017

I have a PR coming that seems to work for me. I'd like to see if it works for you.

@arve0 arve0 mentioned this issue Aug 20, 2017
Merged
@arve0 arve0 closed this as completed in #45 Aug 20, 2017
@arve0
Copy link
Owner

arve0 commented Aug 20, 2017

Fixed in v1.0.1.

@zmiKaminski
Copy link

@zentuit I am experiencing this same error as you but with markdown-it-attrs 1.0.1 & 1.1.0 using uglify-js 3.1.0. Perhaps you can tell me what version combination is working for you?

@arve0
Copy link
Owner

arve0 commented Sep 12, 2017

@zmiKaminski You can use the browser build like this:

var attrs = require('markdown-it-attrs/markdown-it-attrs.browser.js')

The browser build does not contain any ES2015.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants