-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAM connection shall stay open even if some peer failed to resolve #3
Comments
do you intend to issue a pull request for this patch? it looks reasonable as far as I can tell |
I was planning to test this and that before submitting a pull request. Hence I called the branch work in progress to solicit comments. I'm not sure if the patch is enough. Eventually, I'd clean it up for a pull request. If you'd rather prefer a few shorter pull request, I'll do that.
Also I'm somewhat puzzled as how to reestablish connection, e.g. when i2p router died. It doesn't look like there is a provision to reestablish SAM connection. |
one pull requests is fine. either way |
as for number 3, when a peer connects, it takes the upload/download stats from the torrent_peer object and stores it in the peer_connection. It's supposed to set the fields in torrent_peer to 0 when it does this. Then as it uploads and downloads more bytes it increments those counters in peer_connection. When it disconnects, it puts back the stats. If the counters in torrent_peer are non-zero, that implies that either some other peer_connection was connected as the same peer, or it got disconnected so quickly after connecting that it never had time to zero those counters out (and perhaps not pick up the stats either) |
Propagate i2p result code, related to arvidn#3
Propagate i2p result code, related to arvidn#3
Propagate i2p result code, related to arvidn#3
Propagate i2p result code, related to arvidn#3
Propagate i2p result code, related to arvidn#3
Propagate i2p result code, related to arvidn#3
remove two repeated subexpressions when calculating piece index and block index
Currently if INVALID_KEY is returned, the connection is getting closed by handle_error. Thus other peer addresses aren't even attempted to resolve... actually they fail with 10009 (The file handle supplied is not valid.)
The text was updated successfully, but these errors were encountered: