-
-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to change save path and rename files w/o touching files on disk #7412
Comments
In particular, it would allow qBittorrent to avoid re-adding a torrent when received metadata, which we currently have to do in order to adjust save path and file names based on metadata. |
In fact, it looks feasible regarding steps 1. and 3. using existing functionality, i.e. it can be achieved using |
@arvidn |
Is the behaviour you're looking for different from removing the torrent and re-adding it with a new save path? I suppose resume data may need to be cleared to some extent, since we won't know if the files exist at the new path or not |
I see, the tracker announce happens twice |
I don't think this would need to be an ABI break. when you say "reset current progress"; you mean essentially to check resume-data and possibly perform a full check of the files, if there turns out to be existing files in the new save directory. Right? |
As I said in #7412 (comment) it is what |
@arvidn
...then metadata processing can be performed asynchronously. |
I think the main new feature, in that scenario and any other that I can think of, is that you need a new state where a torrent is "started" and has announced to trackers once, but it's still in a somewhat paused state. When it has downloaded the metadata but hasn't applied it yet, there are a lot of cases that needs to be considered while in that state. |
I wouldn't invent any new states. From the client (i.e. application) perspective it may look exactly the same as before, i.e. a torrent that does not have metadata. We need to add the following:
|
Otherwise it can be done if |
#7412 (comment) looks like a more flexible feature, since it has a more general/abstract purpose, so it could be also used in some other scenarios. |
pause after metadata received flag? |
How could it help me? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
For some purposes, it would be very convenient to have a way to change torrent save path and rename files without touching files on disk. I.e.:
The text was updated successfully, but these errors were encountered: