Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a fast-path for the hash disk job #3112

Merged
merged 1 commit into from Jun 19, 2018
Merged

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Jun 16, 2018

This patch reads entire pieces at a time when hashing them, unless we already have some mixed in blocks already in the cache, in which case we use the existing (slow-path) that reads one block at a time

@codecov-io
Copy link

codecov-io commented Jun 17, 2018

Codecov Report

Merging #3112 into RC_1_1 will decrease coverage by <.01%.
The diff coverage is 74.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           RC_1_1    #3112      +/-   ##
==========================================
- Coverage   66.59%   66.59%   -0.01%     
==========================================
  Files         376      376              
  Lines       61234    61266      +32     
  Branches     9749     9754       +5     
==========================================
+ Hits        40777    40798      +21     
+ Misses      16015    16007       -8     
- Partials     4442     4461      +19
Impacted Files Coverage Δ
src/disk_io_thread.cpp 65.86% <74.72%> (+0.05%) ⬆️
include/libtorrent/peer_connection.hpp 76.99% <0%> (-2.66%) ⬇️
src/close_reason.cpp 18.88% <0%> (-2.23%) ⬇️
src/utp_stream.cpp 74.09% <0%> (-0.8%) ⬇️
src/choker.cpp 33.33% <0%> (-0.7%) ⬇️
src/kademlia/routing_table.cpp 65.63% <0%> (-0.67%) ⬇️
src/escape_string.cpp 78.81% <0%> (-0.5%) ⬇️
src/torrent.cpp 53.6% <0%> (-0.37%) ⬇️
src/ut_pex.cpp 59.31% <0%> (-0.35%) ⬇️
src/piece_picker.cpp 88.79% <0%> (-0.07%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae262d...7af1178. Read the comment docs.

@arvidn arvidn force-pushed the hash-job-performance-1.1 branch 2 times, most recently from 76a004d to 3150a81 Compare June 18, 2018 16:20
@arvidn arvidn merged commit 0c14716 into RC_1_1 Jun 19, 2018
@arvidn arvidn deleted the hash-job-performance-1.1 branch June 19, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants