Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to create an affinity to pick adjecent pieces #3913

Merged
merged 1 commit into from Aug 17, 2019

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Aug 5, 2019

aligned to 4MiB extents. It's an attempt to improve disk I/O, by writing larger contiguous ranges of bytes. It's off by default.

@@ -208,6 +208,7 @@ constexpr int CLOSE_FILE_INTERVAL = 0;
SET(proxy_tracker_connections, true, nullptr),
SET(enable_ip_notifier, true, &session_impl::update_ip_notifier),
SET(dht_prefer_verified_node_ids, true, &session_impl::update_dht_settings),
SET(piece_extent_affinity, false, nullptr),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's off by default

@arvidn arvidn force-pushed the piece-picker-extent-affinity-1.2 branch from d44b2f9 to 8556b5d Compare August 5, 2019 21:28
@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #3913 into RC_1_2 will increase coverage by 0.09%.
The diff coverage is 91.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           RC_1_2    #3913      +/-   ##
==========================================
+ Coverage   74.17%   74.26%   +0.09%     
==========================================
  Files         439      439              
  Lines       60032    60169     +137     
  Branches     8908     8930      +22     
==========================================
+ Hits        44529    44685     +156     
+ Misses      11021    11012       -9     
+ Partials     4482     4472      -10
Impacted Files Coverage Δ
include/libtorrent/piece_picker.hpp 89.18% <ø> (ø) ⬆️
include/libtorrent/settings_pack.hpp 100% <ø> (ø) ⬆️
src/settings_pack.cpp 75.21% <ø> (ø) ⬆️
src/alert.cpp 56.43% <ø> (ø) ⬆️
include/libtorrent/alert_types.hpp 58.33% <ø> (ø) ⬆️
test/test_piece_picker.cpp 99.13% <100%> (+0.06%) ⬆️
src/peer_connection.cpp 58.55% <33.33%> (-0.98%) ⬇️
src/piece_picker.cpp 87.47% <75.6%> (-0.51%) ⬇️
test/test_remove_torrent.cpp 90.9% <0%> (-3.9%) ⬇️
src/kademlia/routing_table.cpp 73.2% <0%> (-3.4%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40ecac...a483860. Read the comment docs.

…4MiB extents. It's an attempt to improve disk I/O, by writing larger contiguous ranges of bytes. It's off by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants