Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new socks5_alert to trouble shoot SOCKS5 proxies #4202

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Dec 21, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #4202 into RC_1_2 will decrease coverage by 0.12%.
The diff coverage is 39.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           RC_1_2    #4202      +/-   ##
==========================================
- Coverage    74.7%   74.57%   -0.13%     
==========================================
  Files         439      439              
  Lines       60537    60582      +45     
  Branches     8950     8963      +13     
==========================================
- Hits        45222    45182      -40     
- Misses      10829    10905      +76     
- Partials     4486     4495       +9
Impacted Files Coverage Δ
test/test_priority.cpp 85.94% <ø> (-0.05%) ⬇️
include/libtorrent/udp_socket.hpp 77.77% <ø> (ø) ⬆️
include/libtorrent/aux_/session_udp_sockets.hpp 100% <ø> (ø) ⬆️
test/test_alert_types.cpp 100% <100%> (ø) ⬆️
src/alert.cpp 56.76% <100%> (+0.33%) ⬆️
include/libtorrent/alert_types.hpp 59.34% <100%> (+0.45%) ⬆️
src/session_udp_sockets.cpp 80.95% <100%> (ø) ⬆️
src/session_impl.cpp 56.09% <100%> (+0.44%) ⬆️
src/udp_socket.cpp 52.16% <20%> (-5.72%) ⬇️
test/test.cpp 48.14% <0%> (-40.75%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bf6c3...6bf9d96. Read the comment docs.

@arvidn
Copy link
Owner Author

arvidn commented Dec 22, 2019

I should expose the new alert to the python binding as well

@sledgehammer999
Copy link
Contributor

Don't forget to add the new alert in fwd.hpp too.
In any case, I have created a test build and a new issue on qbt bug tracker to track all relevant progress. If you like, follow user reports here: qbittorrent/qBittorrent#11735

@arvidn arvidn merged commit 0675bd2 into RC_1_2 Dec 28, 2019
@arvidn arvidn deleted the socks5_alert branch December 28, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants