Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict socks5 UDP tunnels to match the address family of the UDP so… #4209

Closed
wants to merge 1 commit into from

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Dec 28, 2019

…cket

@codecov-io
Copy link

Codecov Report

Merging #4209 into RC_1_2 will increase coverage by 0.16%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           RC_1_2    #4209      +/-   ##
==========================================
+ Coverage   74.62%   74.78%   +0.16%     
==========================================
  Files         439      439              
  Lines       60582    60600      +18     
  Branches     8962     8966       +4     
==========================================
+ Hits        45208    45321     +113     
+ Misses      10871    10792      -79     
+ Partials     4503     4487      -16
Impacted Files Coverage Δ
include/libtorrent/udp_socket.hpp 77.77% <ø> (ø) ⬆️
src/socks5_stream.cpp 59.48% <100%> (+1.5%) ⬆️
src/udp_socket.cpp 53.07% <78.57%> (+0.91%) ⬆️
src/choker.cpp 17.07% <0%> (-4.88%) ⬇️
test/web_seed_suite.cpp 89% <0%> (-1.5%) ⬇️
src/close_reason.cpp 20% <0%> (-1.12%) ⬇️
src/request_blocks.cpp 79.24% <0%> (-0.95%) ⬇️
include/libtorrent/peer_connection.hpp 71.79% <0%> (-0.86%) ⬇️
include/libtorrent/torrent.hpp 81.48% <0%> (-0.62%) ⬇️
src/block_cache.cpp 75.46% <0%> (-0.4%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0675bd2...667f2c7. Read the comment docs.

@arvidn
Copy link
Owner Author

arvidn commented Jan 8, 2020

I'm working on a more comprehensive patch that will do this better. I will probably not land this one

@arvidn
Copy link
Owner Author

arvidn commented Jan 15, 2020

superseded by #4249

@arvidn arvidn closed this Jan 15, 2020
@arvidn arvidn deleted the socks5-same-address-family branch January 15, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants