Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start upnp per listen_socket_t #4262

Merged
merged 5 commits into from
Jan 20, 2020
Merged

start upnp per listen_socket_t #4262

merged 5 commits into from
Jan 20, 2020

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Jan 19, 2020

This simplifies the UPnP class to only be responsible for a single subnet.

@arvidn arvidn force-pushed the move-upnp-per-device branch 2 times, most recently from 3c3d477 to 0372083 Compare January 19, 2020 12:09
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #4262 into RC_1_2 will increase coverage by 0.18%.
The diff coverage is 55.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##           RC_1_2   #4262      +/-   ##
=========================================
+ Coverage   74.31%   74.5%   +0.18%     
=========================================
  Files         438     438              
  Lines       60633   60681      +48     
  Branches     8953    8967      +14     
=========================================
+ Hits        45058   45208     +150     
+ Misses      11101   10973     -128     
- Partials     4474    4500      +26
Impacted Files Coverage Δ
include/libtorrent/upnp.hpp 78.26% <ø> (ø) ⬆️
include/libtorrent/enum_net.hpp 6.66% <ø> (ø) ⬆️
include/libtorrent/aux_/session_impl.hpp 72.04% <ø> (ø) ⬆️
src/enum_net.cpp 65.97% <ø> (+5.51%) ⬆️
test/test_transfer.cpp 76.71% <100%> (+0.1%) ⬆️
test/test_session.cpp 93.58% <100%> (-0.33%) ⬇️
src/session_impl.cpp 55% <34.61%> (-0.82%) ⬇️
test/test_upnp.cpp 71.32% <57.14%> (-4.57%) ⬇️
src/upnp.cpp 46.03% <59.21%> (-0.53%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53d3a8...4b34e55. Read the comment docs.

src/session_impl.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants