Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower TCP keepalive timeout for SOCKS5 UDP tunnel #4290

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Jan 29, 2020

to detect network failures and retry

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #4290 into RC_1_2 will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           RC_1_2    #4290      +/-   ##
==========================================
- Coverage    74.2%   74.15%   -0.05%     
==========================================
  Files         438      439       +1     
  Lines       60719    60739      +20     
  Branches     8975     8979       +4     
==========================================
- Hits        45056    45043      -13     
- Misses      11171    11216      +45     
+ Partials     4492     4480      -12
Impacted Files Coverage Δ
include/libtorrent/aux_/keepalive.hpp 100% <100%> (ø)
src/udp_socket.cpp 50.13% <18.18%> (-1.08%) ⬇️
src/timestamp_history.cpp 62.96% <0%> (-29.63%) ⬇️
src/disk_io_thread_pool.cpp 65.85% <0%> (-6.1%) ⬇️
src/ut_pex.cpp 53.54% <0%> (-5.32%) ⬇️
test/swarm_suite.cpp 79.09% <0%> (-2.73%) ⬇️
src/pe_crypto.cpp 68.44% <0%> (-2.14%) ⬇️
test/web_seed_suite.cpp 89% <0%> (-1.5%) ⬇️
test/test_ed25519.cpp 97.26% <0%> (-1.37%) ⬇️
include/libtorrent/torrent.hpp 80.24% <0%> (-1.24%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a88ffc...b9b6942. Read the comment docs.

@arvidn arvidn added this to the 1.2.4 milestone Jan 30, 2020
@arvidn
Copy link
Owner Author

arvidn commented Feb 1, 2020

I was hoping someone would test this patch. But I feel pretty confident it won't make things worse

@arvidn arvidn merged commit bc6444a into RC_1_2 Feb 1, 2020
@arvidn arvidn deleted the socks5-keepalive branch February 1, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants