Pick up and send undersized uTP packets when a packet is 'forced' #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks reasonable |
|
there is at least one simulation test that counts exactly how many packets are sent in a few scenarios. You'll need to update those numbers to make the test pass. (and make sure those changes matches your understanding of what aught to happen with this patch). |
|
see this test: This is |
|
Those numbers look about right. An increase in payload packets transferred as the undersized packets are now piggy-backing on the previously 'ack only' packets, and a decrease in total packets transferred. I'll update the expected test numbers to match. |
…room in the congestion window when 'forcing' a packet
arvidn
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undersized (<MTU) uTP packets are held back in order to reduce overhead (ie. large headers relative to actual payload). Currently, libtorrent can 'force' send a uTP header-only packet without a payload (such as a deferred ack) while an undersized packet is being held back, negating any gains made from holding it back.
This suggested change will pick up and send the undersized packet when a uTP packet is being 'forced' out if there is room in the congestion window to do so.
See #6935