Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with cmake #767

Merged
merged 3 commits into from May 29, 2016
Merged

Fix compilation with cmake #767

merged 3 commits into from May 29, 2016

Conversation

zeule
Copy link
Contributor

@zeule zeule commented May 29, 2016

No description provided.

@zeule zeule changed the title Fix tests compilation with cmale Fix compilation with cmale May 29, 2016
@zeule zeule changed the title Fix compilation with cmale Fix compilation with cmake May 29, 2016
@codecov-io
Copy link

codecov-io commented May 29, 2016

Current coverage is 59.58%

Merging #767 into master will decrease coverage by <.01%

  1. 17 files (not in diff) in src were modified. more
    • Misses +19
    • Partials -8
    • Hits -11
  2. 4 files (not in diff) in include/libtorrent were modified. more
    • Misses +1
    • Partials -1
@@             master       #767   diff @@
==========================================
  Files           264        264          
  Lines         42209      42209          
  Methods        4530       4530          
  Messages          0          0          
  Branches       6754       6754          
==========================================
- Hits          25161      25150    -11   
- Misses        13288      13308    +20   
+ Partials       3760       3751     -9   

Powered by Codecov. Last updated by 420b5f5...510415b

@arvidn
Copy link
Owner

arvidn commented May 29, 2016

thanks. I'm not all that familiar with cmake, I take it you feel confident with these changes? (I think most are obvious, but not all). We should probably be a cmake build in the travis build matrix too.

@arvidn arvidn merged commit 9489eb2 into arvidn:master May 29, 2016
@zeule
Copy link
Contributor Author

zeule commented May 29, 2016

Thank you. Well, I hadn't tried it in a live install yet. Will add python bindings to the cmake build and live test everything then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants