Suppress conditional ujson/json import-related mypy errors.

arviz-devs · Jan 9, 2021 · a27b0fa · a27b0fa
1 parent 0495e84
commit a27b0fa
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/arviz/data/base.py b/arviz/data/base.py
@@ -12,7 +12,9 @@
 try:
     import ujson as json
 except ImportError:
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 from .. import __version__, utils
 

diff --git a/arviz/data/inference_data.py b/arviz/data/inference_data.py
@@ -20,7 +20,9 @@
 try:
     import ujson as json
 except ImportError:
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 SUPPORTED_GROUPS = [
     "posterior",

diff --git a/arviz/data/io_json.py b/arviz/data/io_json.py
@@ -6,7 +6,9 @@
     import ujson as json
 except ImportError:
     # Can't find ujson using json
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 
 def from_json(filename):

diff --git a/arviz/data/io_pystan.py b/arviz/data/io_pystan.py
@@ -17,7 +17,9 @@
     import ujson as json
 except ImportError:
     # Can't find ujson using json
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 
 class PyStanConverter: