Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance on io_pymc3, io_pyro and tests #1227

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Maintenance on io_pymc3, io_pyro and tests #1227

merged 9 commits into from
Jun 10, 2020

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jun 7, 2020

Description

fix #712 and close #1165, related to #939. Test skipping taken from https://github.com/matplotlib/matplotlib/blob/154a936d5f1bed2474af43aaa8572513fecb9f4e/lib/matplotlib/tests/test_animation.py#L135

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1227 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   93.11%   93.13%   +0.02%     
==========================================
  Files          95       95              
  Lines        9609     9614       +5     
==========================================
+ Hits         8947     8954       +7     
+ Misses        662      660       -2     
Impacted Files Coverage Δ
arviz/data/io_pymc3.py 93.33% <ø> (ø)
arviz/data/io_pyro.py 97.33% <100.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661e057...759bdb9. Read the comment docs.

@OriolAbril
Copy link
Member Author

Ready to merge

@canyon289 canyon289 merged commit a32424e into master Jun 10, 2020
@OriolAbril OriolAbril deleted the maintenance branch June 10, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants