-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic conversion of list type to ndarray #1277
Comments
Sir, can you guide me how can i get access to the plot library so that i can resolve this issue... Thanks!! |
Hi @Shreyaansh-darkside, thanks for your interest in ArviZ! We have a detailed contributing guide that should guide you through all the steps to successfully send a pull request to ArviZ. It includes both reference links and the commands to run in the terminal for everything to work. If there is anything not clear enough please let us know so we can update and improve the guide. |
@Shreyaansh-darkside Excited to see that you want to contribute! What @OriolAbril posted is the best guide! Looking forward to the PR. I'll assign this one to you here so it's clear you're attempting it. Thanks again |
Sir PR has been given... waiting to be merged.. |
@canyon289 @OriolAbril Can I please work on this if it is not yet completed. This is similar to my previous commit. |
This is completed.. You can look for other issues.
…On Fri, Jul 24, 2020, 8:17 PM Samasth N A ***@***.***> wrote:
@canyon289 <https://github.com/canyon289> @OriolAbril
<https://github.com/OriolAbril> Can I please work on this if it is not
yet completed. This is similar to my previous commit.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQRYSCYPG6CDQ3XFPENO53R5GNJBANCNFSM4OQDS3OA>
.
|
@Samasth there is no rush in getting this done, @Shreyaansh-darkside has already submmited a pull request and only has to address a couple comments. Therefore it can not be considered old nor abandoned which are the conditions for someone else to start working on the issue as explained in the contributing guide. @Samasth we appreciate you commenting here in the issue before starting to work on it though, we don't want to have two contributors working on the same issue and duplicating work. If you want to contribute but don't find anything suitable for you in the currently open issues, you can ask on gitter explaining the topics more interesting to you so we can help you navigate the issues or even create some new ones, there are more things to modify and we have more ideas to implement than there are opened issues. @Shreyaansh-darkside do work at your own pace and don't hesitate to ask questions if the comments on the review are not clear enough. |
@OriolAbril @Shreyaansh-darkside Sorry for the misunderstanding, I am new here. @OriolAbril Thanks for letting me know I will look into it. |
@Shreyaansh-darkside I must point out this is started but not done. If you get a second can you look at Ari's comment and address, as well as add a test? That will ensure the code is maintainable and flexible in many situations! |
@Samasth If you are still interested this issue is open again. No worries if not but just wanted to let you know |
@canyon289 Thank you. Please assign it to me. i'll start working on it. |
Tell us about it
It would be nice if list types were automatically converted to ndarray in
az.plot_dist
The text was updated successfully, but these errors were encountered: