Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from_cmdstanpy converter to follow schema convention #1550

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

utkarsh-maheshwari
Copy link
Contributor

Description

Matched sample stats according to InferenceData schema specification in from_cmdstanpy converter. Addreses issue #1514

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1550 (e520a79) into main (f4606e4) will increase coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
+ Coverage   90.27%   91.07%   +0.79%     
==========================================
  Files         105      105              
  Lines       11397    11362      -35     
==========================================
+ Hits        10289    10348      +59     
+ Misses       1108     1014      -94     
Impacted Files Coverage Δ
arviz/data/io_cmdstanpy.py 98.20% <100.00%> (+37.50%) ⬆️
arviz/plots/hdiplot.py 88.13% <0.00%> (-4.32%) ⬇️
arviz/plots/violinplot.py 83.33% <0.00%> (-3.04%) ⬇️
arviz/plots/forestplot.py 91.17% <0.00%> (-2.58%) ⬇️
arviz/plots/posteriorplot.py 87.50% <0.00%> (-2.50%) ⬇️
arviz/utils.py 87.34% <0.00%> (-1.95%) ⬇️
arviz/plots/densityplot.py 88.88% <0.00%> (-1.50%) ⬇️
arviz/stats/stats.py 96.12% <0.00%> (-0.45%) ⬇️
arviz/plots/loopitplot.py 97.72% <0.00%> (ø)
arviz/plots/backends/bokeh/loopitplot.py 94.87% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4606e4...f7e0b40. Read the comment docs.

@OriolAbril
Copy link
Member

Hi @utkarsh-maheshwari sorry for the inconvenience, a new cmdstanpy version was released and broke the ci tests, so we merged a fix before merging this PR. You'll now need to rebase/merge the latest changes and most importantly, handle the merge conflicts that arise. Not sure if you have ever handled merge conflicts, if you need help let us know

@OriolAbril
Copy link
Member

Note: also fix the links in the first bullet point of changelog.

@utkarsh-maheshwari
Copy link
Contributor Author

Not sure if you have ever handled merge conflicts, if you need help let us know

Okay, I would like to attempt it first and would seek help if any issue is there. Thanks!

@OriolAbril OriolAbril merged commit 8a6ca10 into arviz-devs:main Feb 15, 2021
@OriolAbril
Copy link
Member

Thanks @utkarsh-maheshwari

@utkarsh-maheshwari utkarsh-maheshwari deleted the update-io_cmdstanpy branch February 16, 2021 02:53
utkarsh-maheshwari added a commit to utkarsh-maheshwari/arviz that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants