Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added significant digits formatter for rope values #1569

Merged
merged 2 commits into from Feb 18, 2021

Conversation

MgeeeeK
Copy link
Contributor

@MgeeeeK MgeeeeK commented Feb 16, 2021

Description

Added significant digits formatter for rope values. To fix #1561

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@MgeeeeK
Copy link
Contributor Author

MgeeeeK commented Feb 16, 2021

Hi @OriolAbril can you take a look

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! You have to run black and add it to the changelog, then we can merge it.

@OriolAbril
Copy link
Member

What version of black do you have? It should not be modifying any unmodified file 🤔

@MgeeeeK
Copy link
Contributor Author

MgeeeeK commented Feb 18, 2021

I was having same doubt looks like my package is outdated (its 19.3b0 installed using conda). Will update and push again.

@OriolAbril
Copy link
Member

You may have to undo the latest commit for this to work. Have you ever done interactive rebase?

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1569 (861677a) into main (1a7f83f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1569   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         105      105           
  Lines       11403    11405    +2     
=======================================
+ Hits        10295    10297    +2     
  Misses       1108     1108           
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/posteriorplot.py 98.16% <100.00%> (+0.01%) ⬆️
arviz/plots/backends/matplotlib/posteriorplot.py 98.26% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7f83f...3bf65e0. Read the comment docs.

@OriolAbril OriolAbril merged commit 1e3356e into arviz-devs:main Feb 18, 2021
@MgeeeeK MgeeeeK deleted the format-rope-values branch February 18, 2021 11:44
utkarsh-maheshwari pushed a commit to utkarsh-maheshwari/arviz that referenced this pull request May 27, 2021
* Added significant digits formatter for rope values

* Added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rope values are not rounded
2 participants