-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix az.from_numpyro
crash when running MCMC with thinning > 1
#1619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, added couple of comments. Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the superfast PR already with tests! ❤️
Thanks for your great suggestions :-) I implemented them and the CI/CD errors do not seem to come from my code. |
Ok, these are not related to your code
I will quickly fix in in another PR. |
Thanks for the PR |
…viz-devs#1619) * Fix crash when importing numpyro model with thinning > 1 * Format code * Add test for numpyro import with thinning * Add entry to CHANGELOG.md * Update link to PR in CHANGELOG.md * Give model tested in 'test_mcmc_with_thinning' a more generic name * Test more MCMC parameters in 'test_mcmc_with_thinning' * Test correct quantity in 'test_mcmc_with_thinning' * Test 'test_mcmc_with_thinning' with multiple chain counts * Simplify implementation of numpyro thinning fix
Description
This PR fixes the crash observed when running the following code:
Fixes #1618 (line edited by @OriolAbril to use github issue closing keywords)
Checklist