Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support PyStan version < 2.18 #189

Merged
merged 2 commits into from
Sep 3, 2018
Merged

support PyStan version < 2.18 #189

merged 2 commits into from
Sep 3, 2018

Conversation

ahartikainen
Copy link
Contributor

This will first try to extract with parameters and permuted=False. In older versions, it will return numpy.array and in later versions a dictionary. If a dictionary is not seen, it will extract again, but permuted=True and then goes to reorder permutation.

Also added lp back to sample_params, it went missing after the "rebase".

@ColCarroll
Copy link
Member

LGTM -- travis failures are:

************* Module arviz.utils.xarray_utils
arviz/utils/xarray_utils.py:310:0: C0301: Line too long (104/100) (line-too-long)
arviz/utils/xarray_utils.py:301:8: C0103: Variable name "lp" doesn't conform to snake_case naming style (invalid-name)
arviz/utils/xarray_utils.py:310:12: C0103: Variable name "lp" doesn't conform to snake_case naming style (invalid-name)
arviz/utils/xarray_utils.py:313:12: C0103: Variable name "lp" doesn't conform to snake_case naming style (invalid-name)
arviz/utils/xarray_utils.py:315:15: W0612: Unused variable 'sampler_dict' (unused-variable)

@ahartikainen
Copy link
Contributor Author

I will still test on my local machine, after that we can merge.

@ahartikainen
Copy link
Contributor Author

Tested with PyStan 2.18 and PyStan 2.17.1. Works now with both of them.

This means that we can start to use pip install pystan in testing.

I will add a change for that too.

@ColCarroll ColCarroll merged commit 1fa564d into master Sep 3, 2018
@ColCarroll
Copy link
Member

Cool!

@ahartikainen ahartikainen deleted the pystan_version_fix branch September 10, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants