-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra argument behavior #191
Conversation
Cool - looks like this change turned up a few legitimate bugs like the one you pointed out in #188:
|
Oh, and I wanted a positional argument so the library would be more explicit and readable. It is easy to remove in the future, but hard to add back in. If it gets too annoying, we can remove! |
It will make usage more robust. Especially important for plotting library where users have used other libs before (e.g mpl) |
especially important if we go with multiple backends |
You mean you wanted a keyword argument? Makes sense and I agree, by forcing people to use keywords itll make it way easier to make changes without breaking peoples code later. |
Oof, sorry, yes, keyword argument. |
Same question as before though! Why force people to use keyword argument?