Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh 3 compatibility [docs] #1919

Merged
merged 3 commits into from Oct 29, 2021
Merged

Bokeh 3 compatibility [docs] #1919

merged 3 commits into from Oct 29, 2021

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Oct 29, 2021

Description

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1919 (e8e6e21) into main (041aced) will increase coverage by 2.89%.
The diff coverage is 100.00%.

❗ Current head e8e6e21 differs from pull request most recent head f9f053e. Consider uploading reports for the commit f9f053e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
+ Coverage   88.34%   91.23%   +2.89%     
==========================================
  Files         117      117              
  Lines       12454    12454              
==========================================
+ Hits        11002    11363     +361     
+ Misses       1452     1091     -361     
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/essplot.py 98.52% <100.00%> (ø)
arviz/data/base.py 98.21% <0.00%> (+0.59%) ⬆️
arviz/data/io_emcee.py 98.34% <0.00%> (+2.47%) ⬆️
arviz/data/io_cmdstanpy.py 95.43% <0.00%> (+34.52%) ⬆️
arviz/data/io_pystan.py 96.08% <0.00%> (+46.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041aced...f9f053e. Read the comment docs.

@ahartikainen ahartikainen changed the title Remove Dash import Remove Dash import [docs] Oct 29, 2021
@ahartikainen ahartikainen changed the title Remove Dash import [docs] Bokeh 3 compatibility [docs] Oct 29, 2021
@ahartikainen ahartikainen merged commit b2258d6 into main Oct 29, 2021
@ahartikainen ahartikainen deleted the fix_bokeh_3 branch October 29, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant