Docs now build locally, and perhaps with no warnings #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't work :( trying again... |
|
It worked? |
|
Nevermind I'm crazy I guess. I swear it just loaded for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think (again) this will fix docs. I installed from github in a fresh environment, and the problem was that
setup.pywill only include files inarviz/arviz, unless we also include aMANIFEST.in. So travis (and my fresh install) could not find the data files thatload_arviz_datauses.I sort of like that we have no MANIFEST.in, and it appears just moving the data folder to the arviz/ directory fixes this.
As an aside it looks like we are also now able to delete the pandas scaffolding that used to be used.