README gallery #204
Merged
README gallery #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canyon289
reviewed
Sep 6, 2018
| 2. Clone this repo, | ||
| 3. Run `./scripts/start_container.sh` | ||
|
|
||
| This should start a local docker container called arviz, as well as a Jupyter notebook server running on port 8888. The notebook should be opened in your browser automatically (you can disable this by passing --no-browser). The container will be running the code from your local copy of arviz, so you can test your changes. |
There was a problem hiding this comment.
I would add one line saying you should run tests, and also can lint code with ./lint.sh if desired
|
You have one commit labels WIP. I think that could have a better commit message! |
|
Interesting - I had thought commits were getting squashed, but I see a few silly commit messages. Do you know an easy way to fix that? Maybe we default to doing "squash and merge"? |
|
I believe thats the way to do it. There's these UI buttons. Squash and rebasing like pymc3 sounds reasonable to me
|
|
Agree "squash and merge" should be the default |
|
I turned off the merge commit and rebase so there should only be one option now |
|
Check hash
and the squash, and fixup if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor edits, but mostly adding a gallery to the readme.
Note that I am linking the images directly to the documentation, instead of internally into the github repo. This is a little risky (if the documentation goes down, the README looks bad), but makes the README portable: the images will still display on pypi, for example.
You can see it at https://github.com/ColCarroll/arviz/tree/pretty-docs