-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break axes labels at selection #227
Conversation
|
Also, do we have possibility to just use coord name? E.g. school : XYZ --> XYZ? |
I'll use your suggestion and make examples after work today. Thanks! |
Looks good. I think if there are more levels, user probably needs to handle it somehow manually? Is there a possibility to select which level to use? |
So the user can override the labels because they the axes objects are returned. I'm sure there's a way to select which level to use, but I don't know how. I can make a multi level example and see what happens. |
Sounds good. I hope users start to use coordinates, make these plots much nicer. |
Will users have a choice? I think if given a pystan or pymc3 object arviz does all the coordinate and dim assignment for them under the hood for most of the plots |
Yes, but like giving names and stuff |
Sorry I dont follow. When you say giving names what do you mean? In the API the only mechanism I see is users selecting a subset of names and coords with the Do you mean the users should specify the names in pystan or pymc3 before they use arviz? I feel like Im asking you a bunch of questions recently, I hope you don't mind :) Thanks for the feedback Edit |
Yes, people have let's say Beta vector of 10 variables, and they have names for each of them. So instead of using only Beta0, ... they can use names for them, and plotting will consider them automagically. It is easier for users to handle more complex datasets. |
This looks beautiful, way better than before! I think using the labels will rely on us providing good examples and docs, and on the default dimension names being so ugly ( |
Per at @ahartikainen comments make the labels a little nicer.
Still not great, but for a two character change I think this is moving the labels in the right direction.
I haven't checked all the plots yet but below are examples from pairplot. They're getting cut off a little but If they generally look good I can fix this and check more plots.