Add Docker Testing to travisCI #473
Conversation
canyon289
force-pushed
the
docker_travis
branch
from
b5d3855
to
fbbcd90
Compare
canyon289
force-pushed
the
docker_travis
branch
from
fbbcd90
to
ec5c5b6
Compare
scripts/Dockerfile
Outdated
| ENV GH_REPO_SLUG=${GH_REPO_SLUG} | ||
|
|
||
| # For Coveralls | ||
| ENV COVERALLS_REPO_TOKEN=${COVERALLS_REPO_TOKEN} |
There was a problem hiding this comment.
We are public so we shouldn't use this.
There was a problem hiding this comment.
Is the concern someone could write code that would print the token?
scripts/Dockerfile
Outdated
| ENV TRAVIS_REPO_SLUG=${TRAVIS_REPO_SLUG} | ||
| ENV TRAVIS_TAG=${TRAVIS_TAG} | ||
| ENV GH_TOKEN=${GH_TOKEN} | ||
| ENV GH_REPO_SLUG=${GH_REPO_SLUG} |
There was a problem hiding this comment.
we need at least TRAVIS_JOB_ID
https://docs.travis-ci.com/user/coveralls/#using-coveralls-with-docker-builds
There was a problem hiding this comment.
This link is very helpful!
canyon289
force-pushed
the
docker_travis
branch
from
f1d9b02
to
128242f
Compare
canyon289
force-pushed
the
docker_travis
branch
from
31dbbec
to
588658f
Compare
canyon289
force-pushed
the
docker_travis
branch
from
e932436
to
d3d2c04
Compare
|
coveralls is working now! The source code is parsed and sent to the coveralls website. The one thing that is broken is the coveralls drilldown view Here's an example of a working one from another PR. We can make the choice of merging this now or fixing coveralls drilldown and merging later. |
|
LGTM |
|
Hi, I did one test before merge. We can remove it if it doesn't work |
|
It did not, se let's rebase and remove that commit and try it in another PR |
canyon289
changed the title
Trying to get testing to be done in containers